fix(common): update locales data to remove � characters #33699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
area: build & ci
IgorMinar
approved these changes
Nov 8, 2019
|
glad that the outcome is good, but overall why is running clang from yarn from shell from shelljs from gulp, good and produces good outcome, but running clang from gulp, bad? I think that the problem is that clang from gulp was not pulling in the correct config |
|
Also, it seems that Edit: looking at the issues, it seems that @IgorMinar was struggling with a similar issue 4(!) years ago |
petebacondarwin
approved these changes
Nov 11, 2019
gkalpak
approved these changes
Nov 11, 2019
devversion
approved these changes
Nov 11, 2019
kara
pushed a commit
that referenced
this pull request
Nov 11, 2019
kara
pushed a commit
that referenced
this pull request
Nov 11, 2019
kara
pushed a commit
that referenced
this pull request
Nov 11, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
clang-formatviagulp-clang-formatwas causing intermittent instances of Unicode's replacement character (\uFFFD/�). By runningclang-formatviashelljsin thegulpscript, this intermittent difference is no longer occurring.Unblocks #33682